Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of unit tests to use KRaft - part 9 #10468

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Aug 19, 2024

Type of change

  • Task

Description

This is part 9 of the update of unit tests to use KRaft. This PR starts with the unit tests for the model classes, mainly related to CC and EO. They are not directly dependent on ZooKeeper, so this PR mostly updates them to use KRaft like Kafka resource (i.e. without ZooKeeper, storage, replicas etc.).

It also implements some generic improvements as part of it. For example better use of the static fields etc.

Checklist

  • Write tests
  • Make sure all tests pass

@scholzj scholzj added this to the 0.44.0 milestone Aug 19, 2024
@scholzj scholzj requested a review from a team August 19, 2024 18:49
Signed-off-by: Jakub Scholz <www@scholzj.com>
@scholzj scholzj force-pushed the wave-9-of-KRaft-unit-test-updates branch from 4e320ee to 0cb5cbe Compare August 19, 2024 20:19
Copy link
Member

@im-konge im-konge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@scholzj scholzj modified the milestones: 0.44.0, 0.43.0 Aug 20, 2024
@scholzj scholzj merged commit 1e7ecb0 into strimzi:main Aug 20, 2024
13 checks passed
@scholzj scholzj deleted the wave-9-of-KRaft-unit-test-updates branch August 20, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants