Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system test] Move TestUtils methods used only in STs to systemtest m… #10610

Merged

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Sep 19, 2024

…odule

Type of change

  • Enhancement / new feature
  • Refactoring

Description

TLDR; This PR solves [1].

A few methods were currently located in the test module, but such methods were only in the systemtest module. Therefore we have decided to move it to the systemtest module.

[1] - #10557

Checklist

  • Make sure all tests pass

…odule

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick requested a review from a team September 19, 2024 13:33
@see-quick see-quick self-assigned this Sep 19, 2024
@see-quick see-quick added this to the 0.44.0 milestone Sep 19, 2024
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks. Should be reviewed by system test SMEs as well.

Signed-off-by: see-quick <maros.orsak159@gmail.com>
@see-quick see-quick added ready for merge Label for PRs which are ready for merge and removed needs review labels Sep 19, 2024
@scholzj
Copy link
Member

scholzj commented Sep 19, 2024

/azp run regression

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@see-quick see-quick merged commit f7c1928 into strimzi:main Sep 20, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for merge Label for PRs which are ready for merge System tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants