Update setup-kind.sh to correctly set docker login and remove unused variables from the script
#10617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
Signed-off-by: Lukas Kral <lukywill16@gmail.com>
|
/packit test --labels regression |
henryZrncik
approved these changes
Sep 20, 2024
Frawless
approved these changes
Sep 20, 2024
jankalinic
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Similarly to
setup-kubernetes.sh, where we are setting the Minikube cluster, insetup-kind.shwe have possibility to "copy docker login" -> meaning that it will basically copy the login to registries from the local machine. This works perfectly for the Minikube cluster, but doesn't work on the Kind cluster -> because we need to update this "pull secret" for every node of the Kind cluster. More about this is mentioned in the documentation - https://kind.sigs.k8s.io/docs/user/private-registries/#use-an-access-tokenOther than fixing this behavior, I'm removing the unused variables, which were copy-pasted from the
setup-kubernetes.sh, but not really used in the script right now. In case of need, we can add it back in the future (from the documentation, we can limit the docker with the CPU and memory requests, but it's not possible for the whole Kind cluster).Checklist