Fix reliability issue with test case #10635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MichaelMorris <michael.morris@est.tech>
scholzj
reviewed
Sep 24, 2024
mockkube/src/test/java/io/strimzi/test/mockkube3/MockKube3ControllersMockTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: MichaelMorris <michael.morris@est.tech>
scholzj
approved these changes
Sep 24, 2024
|
Thanks for the PR. |
see-quick
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
I assume you successfully reproduce this issue locally and after this fix everything works well @MichaelMorrisEst? Anyway thanks for working on this LGTM 👍.
|
@see-quick Yes I was able to reproduce locally (intermittently but reasonably often). After applying the fix, despite trying many times I can no longer reproduce, so all looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Addresses reliability issue with MockKube3ControllersMockTest.testDeploymentController test case by changing the wait condition to wait until after the MockDeploymentController has processed the deployment creation
Closes #10616
Checklist
Please go through this checklist and make sure all applicable tasks have been done