Clean-up the KafkaClusterCreator class after ZooKeeper removal
#10997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
/azp run regression |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ppatierno
approved these changes
Dec 29, 2024
scholzj
deleted the
clean-KafkaClusterCreator-after-zookeeper-removal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
While ZooKeeper support was cleaned from most of our code, the
KafkaClusterCreatorstill had the parts where it expected replicas to be configured in the Kafka CR directly instead of in the node pools. This cannot happen anymore after ZooKeeper removal, so this PR cleans up theKafkaClusterCreatorclass to cover reverting scale-down only in the KafkaNodePool resources. The related tests were already deleted with ZooKeeper, so there are no tests to delete.Checklist