Add Podman Compatibility and Enhance Kind cluster setup #11086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <maros.orsak159@gmail.com>
|
Why most of the already existing commands are now started via |
Frawless
reviewed
Jan 28, 2025
Mainly because we have to run kind of as |
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
…on required. Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
im-konge
approved these changes
Jan 31, 2025
|
/azp run acceptance |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Frawless
approved these changes
Feb 3, 2025
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
jankalinic
reviewed
Feb 6, 2025
| } | ||
|
|
||
| function label_node { | ||
| # It should work for all clusters | ||
| for nodeName in $(kubectl get nodes -o custom-columns=:.metadata.name --no-headers); | ||
| for nodeName in $($SUDO kubectl get nodes -o custom-columns=:.metadata.name --no-headers); |
There was a problem hiding this comment.
should $SUDO be used everywhere?
There was a problem hiding this comment.
Yeah, because if do not execute with sudo you will not see kind cluster as we previously started kind as sudo
|
/packit test --labels acceptance |
Frawless
reviewed
Feb 6, 2025
| // Kaniko pushes the image to the local registry, but Podman stores it in an internal storage | ||
| // that is not directly accessible to Kind. Podman must first pull the image from the registry | ||
| // so that it is available in the Podman daemon's local storage before "kind load" can work. | ||
| Exec.exec("sudo", "podman", "pull", image); |
There was a problem hiding this comment.
what if I will use kind with docker?
There was a problem hiding this comment.
I think I should add some wrapper to check your container runtime and base on that just use podman/docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR introduces Podman compatibility to the KIND cluster setup script. It seamlessly allows users to use Docker or Podman as their container runtime. The changes ensure proper configuration and support for Kubernetes cluster provisioning.
Checklist