Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MO] - TopicOperatorIT using shared TO (execution time from ~30m -> 6m) #6401

Merged
merged 1 commit into from
Feb 28, 2022
Merged

[MO] - TopicOperatorIT using shared TO (execution time from ~30m -> 6m) #6401

merged 1 commit into from
Feb 28, 2022

Conversation

see-quick
Copy link
Member

@see-quick see-quick commented Feb 20, 2022 •
edited
Loading

Signed-off-by: morsak xorsak02@stud.fit.vutbr.cz

Type of change

  • Enhancement / new feature
  • Refactoring

Description

This PR refactoring TopicOperator integration tests. Specifically TopicOperatorBaseIT family. Two things, which has been done:

  1. Move Kafka setup for ∀ test cases for each test suite (reduction time approximately 3 minutes in total)
  2. Move Deployment of Topic Operator to @BeforeAll making him sharable between test cases (reduction time approximately 21 minutes in total)

Build pipeline - before
image

Build pipeline - after

image

Checklist

  • Make sure all tests pass

[MO] - TopicOperatorIT using shared TO (execution time from ~30m -> 6m)
94a766e 
Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
@see-quick see-quick added this to the 0.29.0 milestone Feb 20, 2022
@see-quick see-quick self-assigned this Feb 20, 2022
scholzj
scholzj approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@scholzj scholzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it works 🤷

@scholzj scholzj merged commit 558cf88 into strimzi:main Feb 28, 2022
@scholzj scholzj mentioned this pull request Feb 28, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scholzj scholzj scholzj approved these changes

@tombentley tombentley tombentley approved these changes

Assignees

@see-quick see-quick

Labels
needs review
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.
3 participants
@see-quick @tombentley @scholzj