-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mutation testing #104
Mutation testing #104
Conversation
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am okay with it, but using @DoNotMutate
to quite a lot of methods within the class looks a little bit strange.
Yeah, but those methods are mainly used in Integration tests or cause a timeout of Mutation minions (e.g., randomUuid). In general, you don't want to include those because I would need to add these tests to UTs and that's not a good approach IMO (f.e., image pulling). Because now they run around 50s and with those tests, it would need like much more... |
This PR adds to the test container mutation testing. Specifically [1]. During adoption, I saw that there are a lot of paths in the
Strimzi*
classes, which are not tested. So I have also added a few tests to solve it.You can read about the benefits of mutation testing here [2].
Moreover, I have updated Azure-CI with mutation testing within the pipeline. Also if someone writes a new code then the build may fail because I have set the following thresholds. So there will be a need to add UTs to cover such features and be at least on such threshold as we have currently.
[1] - https://pitest.org/
[2] - https://www.arcmutate.com/benefits/