Removes finally blocks and add @AfterEach to each ITs to stop running container #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: see-quick <maros.orsak159@gmail.com>
|
I don't follow this. Why should there be no running containers? |
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Signed-off-by: see-quick <maros.orsak159@gmail.com>
Each test case has its resources. Currently, we do not use shared resources across more tests. As I have tested now, there is no need to use that precondition and only |
see-quick
changed the title
im-konge
approved these changes
Nov 28, 2024
jankalinic
approved these changes
Nov 28, 2024
see-quick
added a commit
to see-quick/test-container
that referenced
this pull request
Dec 4, 2024
… container (strimzi#118) * Add precondition to ITs that no containers are running Signed-off-by: see-quick <maros.orsak159@gmail.com> * not needed filtering Signed-off-by: see-quick <maros.orsak159@gmail.com> * also add un-necessary labels Signed-off-by: see-quick <maros.orsak159@gmail.com> --------- Signed-off-by: see-quick <maros.orsak159@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes and removed the
finallyblock and instead added the @AfterEach annotation to IT suites that were missing it.Solves #100