Add option to enable logging into stdout using env variable

[see-quick]

This PR adds an option to enable logging into stdout using the env variable STRIMZI_TEST_CONTAINER_LOGGING_ENABLED.

An example of the log can be found [1].

[1] - https://gist.githubusercontent.com/see-quick/8d88a97b533f8910ec2af135071b6ab7/raw/57e6cc73e8a875de75e0655677fac30bba5b67f8/gistfile1.txt

[scholzj]

Why do you call it logToConsole in one place and BrokerContainerSlf4jLogging in the other? Would the same name everywhere make sense? Also, having javadocs explaining what it actually does would help. console has many meanings for example.

Also, would some environment variable or system property be better for a switch like that? If you aim this for troubleshooting, then you likely do not want to modify the tests to troubleshooth but for example just set an environment variable maybe?

[Frawless]

Also, would some environment variable or system property be better for a switch like that? If you aim this for troubleshooting, then you likely do not want to modify the tests to troubleshooth but for example just set an environment variable maybe?

Wouldn't be better to log it to file instead of to console? Guess it can pollute the log quite quickly in case user will have more than few containers.

[see-quick]

Also, would some environment variable or system property be better for a switch like that? If you aim this for troubleshooting, then you likely do not want to modify the tests to troubleshooth but for example just set an environment variable maybe?

Wouldn't be better to log it to file instead of to console? Guess it can pollute the log quite quickly in case user will have more than few containers.

So in that case I think it would be best to call getLogs() (if something bad happens) and append it to the logs files inside /target/strimzi-test-container/<date> as we have for instance LogCollector.

Also, would some environment variable or system property be better for a switch like that? If you aim this for troubleshooting, then you likely do not want to modify the tests to troubleshooth but for example just set an environment variable maybe?

Yeah, this is a good point. I think it would be better to use ENV or system property here. The main reason it to just enhance current troubleshooting in CI.

Wouldn't be better to log it to file instead of to console? Guess it can pollute the log quite quickly in case user will have more than few containers.

That said we could have both options:

1. [1] @Frawless, where a user wants to collect all logs and store it somewhere... (using getLogs())
2. And ENV to enable console output for container.

[1] - #119

[see-quick]

Any opinions on this @scholzj @Frawless? I can start with just:

1. Add ENV to enable console output for the container.

That would be the easiest way possible.

[Frawless]

Any opinions on this @scholzj @Frawless? I can start with just:

1. Add ENV to enable console output for the container.

That would be the easiest way possible.

Yes, sounds reasonable to me.

I am thinking about option to force logging without env for certain situations/tests and I don't have strong opinion. I can imagine situations that might be useful, but user can also achieve ti with ENV option that will of course turn on logging for everything.

[scholzj]

Maybe you should update the PR description and add something to the README.md file?

[see-quick]

Maybe you should update the PR description and add something to the README.md file?

Yeah, thanks for it. I have updated it.