-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MO] - expose internal ZooKeeper to be able connect via external comp… #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scholzj
approved these changes
Feb 18, 2022
src/main/java/io/strimzi/test/container/StrimziKafkaContainer.java
Outdated
Show resolved
Hide resolved
…onents (ZkClient etc.) Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
…utes has no value/ Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
…new construor \+ predicates Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
Signed-off-by: morsak <xorsak02@stud.fit.vutbr.cz>
see-quick
force-pushed
the
internal-zookeeper-up
branch
from
February 20, 2022 08:20
f4bd650
to
64d0a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…onents (ZkClient etc.)
StrimziKafkaContainer
Currently, in StrimziKafkaContainer we are not able to connect to internal ZooKeeper, which is running inside the same container as Kafka. This PR exposes such ZooKeeper and adds a few test cases to proper check implementation.
Moreover adds a few helpful stuff such as:
StrimziKafkaCluster
StrimziZooKeeperCluster
Signed-off-by: morsak xorsak02@stud.fit.vutbr.cz