Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge: Generate code for Joplin - Gladiolus Rag #78

Open
rvilarl opened this issue Jan 17, 2023 · 10 comments
Open

Challenge: Generate code for Joplin - Gladiolus Rag #78

rvilarl opened this issue Jan 17, 2023 · 10 comments

Comments

@rvilarl
Copy link
Collaborator

rvilarl commented Jan 17, 2023

The good news: no crash reading the XML file.
The challenge: quite a few things to fix.

image

@rvilarl
Copy link
Collaborator Author

rvilarl commented Jan 17, 2023

Our target :)

image

@jaredjj3
Copy link
Collaborator

I like this approach. It gives us concrete bugs to work on. The cross-staff notations are particularly interesting.

@jaredjj3
Copy link
Collaborator

@rvilarl, would you attach the MusicXML file somewhere in this issue please?

@rvilarl
Copy link
Collaborator Author

rvilarl commented Dec 11, 2023

The score is this one https://musescore.com/user/58480/scores/1749906

@jaredjj3
Copy link
Collaborator

jaredjj3 commented Jan 2, 2024

Good catch, I think we can fix this by adding a check here and making the BeamRendering.vexflow.beam nullable.

@rvilarl
Copy link
Collaborator Author

rvilarl commented Jan 28, 2024

The cross staff notations are no longer there in measure 5

image

@rvilarl
Copy link
Collaborator Author

rvilarl commented Jan 28, 2024

@jaredjj3 also starting on measure 10 the second staff is missing.

image

@jaredjj3
Copy link
Collaborator

There must be a bug with beaming. This will be a good score to thoroughly test the system.

@jaredjj3 jaredjj3 self-assigned this May 26, 2024
@jaredjj3
Copy link
Collaborator

I'm going to take another stab at this before going back to lilypond specs. Here's what I plan to work on:

  • Ensure that the top of a rendering is present.
  • Prevent ties from rendering across systems.
  • Investigate increasing StaveTie height, part distance, or both.
  • Render repeats.

vexml_dev_0_0_0 (1)

@jaredjj3 jaredjj3 mentioned this issue May 28, 2024
4 tasks
@jaredjj3 jaredjj3 removed their assignment Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants