Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track status changes, voice status changes, and games (activities) #51

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Track status changes, voice status changes, and games (activities) #51

wants to merge 24 commits into from

Conversation

emmiegit
Copy link
Collaborator

@emmiegit emmiegit commented Apr 4, 2018

Updates the old branch to use the new concept of the "activity", and properly handle status changes and activity updates.

@emmiegit emmiegit requested a review from robstolarz April 4, 2018 00:12
jchristgit
jchristgit reviewed Apr 13, 2018
View reviewed changes
statbot/status.py Outdated Show resolved Hide resolved
@emmiegit emmiegit changed the title Track status changes and games Track status changes, voice status changes, and games (activities) Apr 14, 2018
@emmiegit
Copy link
Collaborator Author

Added tracking for voice status changes.

jchristgit
jchristgit reviewed Apr 14, 2018
View reviewed changes
Copy link

@jchristgit jchristgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still don't fully know what this thing does, tales tell that it's some mini-facebook thing for discord. haven't found much to "review", i don't know why you asked me to, but since you asked for it, here's a bunch of useless review comments

statbot/sql.py Show resolved Hide resolved
statbot/sql.py Show resolved Hide resolved
statbot/sql.py Show resolved Hide resolved
statbot/sql.py Show resolved Hide resolved
statbot/sql.py Show resolved Hide resolved
statbot/sql.py Outdated Show resolved Hide resolved
statbot/status.py Show resolved Hide resolved
Ammon Smith added 24 commits June 5, 2018 15:31
Add schema changes for status and game.
54c6d0b
Hook in events for status and game changes.
dd590cd
Fix SQL name conflict.
300f6c0
Add game and status it _init_sql()
e72d793
Fix bug in remove_all_members().
b3ee9d2
Fix constraint in special insertion.
660a9da
Add schema changes for status and game.
e433b24
Fix SQL name conflict.
bdfcb11
Add schema changes for status and game.
02382b6
Fix SQL name conflict.
dd2b464
Fix bug in remove_all_members().
85b108f
Add schema changes for status and game.
0601369
Hook in events for status and game changes.
508ed5e
Fix SQL name conflict.
d8475cf
Add game and status it _init_sql()
4b6cad7
Rename 'status' column to avoid conflict.
51f0122
Add UserStatus enum.
5d3bd67
Running fixes.
eb8212e
Only add fields to JSON if they exist.
925754f
Other update improvements.
3b182ee
Use constant dictionary for UserStatus conversion.
89efb35
Fix pylint issue.
6e29251
Add tracking for voice event changes.
a5c6978
Use with_only_columns() to restrict SELECT.
2e4b2e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchristgit jchristgit jchristgit left review comments

@raylu raylu raylu left review comments

@robstolarz robstolarz Awaiting requested review from robstolarz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmiegit @raylu @jchristgit