-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing builds and PHP 8 support #8
Failing builds and PHP 8 support #8
Comments
I noticed that after removing the Here's the steps I did to reproduce the error on my local machine:
After removing
|
yeah feel free to remove composer.lock. That seems peaceful |
Tests with PHP 8 were failing because some of the dependencies did not expect newer PHP in the lock file. If we can remove it like other repositories (e.g., checkout-one-time-payments), the tests won't fail for the same reason in the future. Fixes stripe-samples/sample-ci#8.
Thanks. I created a PR that removes the lock files: stripe-archive/accept-a-card-payment#69 |
Tests with PHP 8 were failing because some of the dependencies did not expect newer PHP in the lock file. If we can remove it like other repositories (e.g., checkout-one-time-payments), the tests won't fail for the same reason in the future. Fixes stripe-samples/sample-ci#8.
Bug report
Describe the bug
It looks like some PHP samples don't support PHP 8. Since the latest composer Docker image bundles PHP 8.0.2, composer failed to satisfy the dependencies in this build in accept-a-card-payment. Considering the cause, I think the other repositories may also have the same issue.
This is the detailed error messages:
To Reproduce
https://github.com/stripe-samples/accept-a-card-payment/runs/1972142343
Expected behavior
The build passes.
Additional context
As for accept-a-card-payment, this PR (stripe-archive/accept-a-card-payment#58) will fix the issue for
without-webhooks
. However, we will need similar changes onusing-webhooks
, too.Also, we could make CI use PHP 7 for now.
The text was updated successfully, but these errors were encountered: