Fix several bugs and minor refactors #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added a more complex example for the tests: Flow which is a very simple data-flow style AST (similar to spark, etc...), but hopefully complex enough to expose more bugs than the addition example. * there was a bug with isRoot, this is fixed * there was a bug in find which could result in needless extra Ids added to the graph * found a proof that the current approach (and maybe all approaches that preserve all Ids) cannot maintain the invariant that each N[_] is the result of evaluating at most one Id[_]. Which is to say evaluate[T](i: Id[T]): N[T] is a many to one function.
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
===========================================
+ Coverage 69.51% 86.38% +16.87%
===========================================
Files 11 12 +1
Lines 164 191 +27
Branches 6 17 +11
===========================================
+ Hits 114 165 +51
+ Misses 50 26 -24
Continue to review full report at Codecov.
|
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added a more complex example for the tests: Flow which is a very
simple data-flow style AST (similar to spark, etc...), but hopefully
complex enough to expose more bugs than the addition example.
there was a bug with isRoot, this is fixed
there was a bug in find which could result in needless extra Ids added
to the graph
found a proof that the current approach (and maybe all approaches that
preserve all Ids) cannot maintain the invariant that each
N[_]is theresult of evaluating at most one
Id[_]. Which is to sayevaluate[T](i: Id[T]): N[T]is a many to one function.
cc @non @erik-stripe