Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proxy-Authorization header support for URL encoded credentials on HTTPS Requests #25

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

pspieker-stripe
Copy link

@pspieker-stripe pspieker-stripe commented Jul 2, 2024

Summary

This PR adds support for passing the Proxy-Authorization header into the CONNECT request from GoProxy to an external proxy.

Testing

  1. Existing tests pass
  2. Rolled this out to QA

@pspieker-stripe pspieker-stripe marked this pull request as ready for review July 5, 2024 20:25
@pspieker-stripe pspieker-stripe changed the title Add Proxy-Authorization header support for URL encoded credentials Add Proxy-Authorization header support for URL encoded credentials on HTTPS Requests Jul 5, 2024
Copy link

@cds2-stripe cds2-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this is just pulling out the UserInfo from the parsed URL to include in proxy auth headers

@cds2-stripe cds2-stripe merged commit e7f34c1 into master Jul 10, 2024
5 checks passed
@cds2-stripe cds2-stripe deleted the pspieker-add-connect-proxy-auth branch July 10, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants