Skip to content

Fix Test Case Indent Formatting #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bplunkett-stripe opened this issue Aug 31, 2023 · 2 comments · Fixed by #139
Closed

Fix Test Case Indent Formatting #67

bplunkett-stripe opened this issue Aug 31, 2023 · 2 comments · Fixed by #139
Labels

Comments

@bplunkett-stripe
Copy link
Collaborator

A lot of the test cases have inconsistent indenting formatting in the SQL. Some uses tabs, some use spaces. As a result, when this is rendered in github, some lines appear more indented than others.

To fix this, we will need to replace all test cases that have tabs indenting with a visual equivalent in spaces.

I'm guessing our go formatting didn't spot this because the SQL is contained within a string, which is presumably ignored by the formatter.

@tanryberdi
Copy link

/assign

@bplunkett-stripe
Copy link
Collaborator Author

bplunkett-stripe commented Sep 1, 2023

I'm excited to have you take on this ticket @tanryberdi .

You can see an example of the problem here, where one column is inconsistently formatted. This problem is pervasive through the acceptance tests (the tests in that package).

Ideally, we should switch all of the tab formatting to spaces, since spaces will be always be consistently rendered.
It would also be nice if we can find a way to enforce that in CI, but I doubt it's possible since the SQL is located in a go string literal.

Feel free to ping me with any questions you have on this ticket!

ammiranda added a commit to ammiranda/pg-schema-diff that referenced this issue Jun 22, 2024
ammiranda added a commit to ammiranda/pg-schema-diff that referenced this issue Jun 25, 2024
ammiranda added a commit to ammiranda/pg-schema-diff that referenced this issue Jun 30, 2024
ammiranda added a commit to ammiranda/pg-schema-diff that referenced this issue Jun 30, 2024
ammiranda added a commit to ammiranda/pg-schema-diff that referenced this issue Jul 2, 2024
ammiranda added a commit to ammiranda/pg-schema-diff that referenced this issue Jul 2, 2024
ammiranda added a commit to ammiranda/pg-schema-diff that referenced this issue Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants