-
Notifications
You must be signed in to change notification settings - Fork 33
Fix Test Case Indent Formatting #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
/assign |
I'm excited to have you take on this ticket @tanryberdi . You can see an example of the problem here, where one column is inconsistently formatted. This problem is pervasive through the acceptance tests (the tests in that package). Ideally, we should switch all of the tab formatting to spaces, since spaces will be always be consistently rendered. Feel free to ping me with any questions you have on this ticket! |
A lot of the test cases have inconsistent indenting formatting in the SQL. Some uses tabs, some use spaces. As a result, when this is rendered in github, some lines appear more indented than others.
To fix this, we will need to replace all test cases that have tabs indenting with a visual equivalent in spaces.
I'm guessing our go formatting didn't spot this because the SQL is contained within a string, which is presumably ignored by the formatter.
The text was updated successfully, but these errors were encountered: