Add support for Postgres17 (+ misc linting changes) #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bplunkett-stripe
force-pushed
the
bplunkett/add-support-for-postgres17
branch
2 times, most recently
from
3895a86 to
b11cdce
Compare
bplunkett-stripe
force-pushed
the
bplunkett/add-support-for-postgres17
branch
from
b11cdce to
45d147a
Compare
| @@ -342,7 +342,7 @@ WHERE | |||
| AND seq_ns.nspname !~ '^pg_temp' | |||
| -- Exclude sequences owned by identity columns. | |||
| -- These manifest as internal dependency on the column | |||
| AND (depend.deptype IS NULL OR depend.deptype != 'i') | |||
| AND (depend.deptype IS null OR depend.deptype != 'i') | |||
There was a problem hiding this comment.
The new version of sqlfluff converts all caps NULL to null, which ensures consistency. Other occurences of null in this file are also lowercase.
alexaub-stripe
previously approved these changes
Dec 11, 2024
alexaub-stripe
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation
Fixes #186
Testing
Testing via CI