Fixing error message for custom entrypoint #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryc-stripe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Skycfg's entrypoint is usually a
main()function, but users are allowed to specify a custom function name if they wish. However, error messages always have the entrypoint hardcoded to "main", which is confusing for users specifying a custom entrypoint.For example, if a user has a custom entrypoint function named
my_entrypointand uses the optionskycfg.WithEntryPoint("my_entryponit")(which has a typo), they will be presented with the error messageno 'main' function found in "file.sky", while a more appropriate error message would beno 'my_entryponit' function found in "file.sky". This PR changes the error message so it always uses the entrypoint provided by the user.