Add support for proto.to_any #46
Conversation
|
@jmillikin-stripe: What do you think about this PR? |
| if "" != proto.MessageName(msg.msg) { | ||
| // Returns a golang any.Any type. | ||
| any, err = ptypes.MarshalAny(msg.msg) | ||
| } else if "" != gogo_proto.MessageName(msg.msg) { |
There was a problem hiding this comment.
We should probably only go here if msg's package has a gogo: prefix to be consistent with previous changes in gogocompat.
Previously @jmillikin-stripe also insisted on gogo dependencies going into separate package to avoid hard dependency within core implementation.
| // Returns a gogo types.Any type. | ||
| any, err = gogo_types.MarshalAny(msg.msg) | ||
| } else { | ||
| return nil, fmt.Errorf("%s: could not get message name for %s", "proto.to_any", msg.Type()) |
There was a problem hiding this comment.
| return nil, fmt.Errorf("%s: could not get message name for %s", "proto.to_any", msg.Type()) | |
| return nil, fmt.Errorf("%s: could not get message name for %s", fn.Name(), msg.Type()) |
| // skyProtoMessage with an `Any` proto.Message in it. | ||
| func fnProtoToAny(t *starlark.Thread, fn *starlark.Builtin, args starlark.Tuple, kwargs []starlark.Tuple) (starlark.Value, error) { | ||
| var msg *skyProtoMessage | ||
| err := wantSingleProtoMessage("proto.to_any", args, kwargs, &msg) |
There was a problem hiding this comment.
| err := wantSingleProtoMessage("proto.to_any", args, kwargs, &msg) | |
| err := wantSingleProtoMessage(fn.Name(), args, kwargs, &msg) |
|
Michael Kipper seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hit this today when trying to use the Envoy API in skycfg. The Envoy It's not currently possible to work around as it's not possible to marshal Skycfg to a protobuf so you can put it into the [0] https://github.com/envoyproxy/data-plane-api/blob/master/envoy/api/v2/listener/listener_components.proto#L29-L43 |
|
Replaced by #83 |
Re: #45
This simple PR adds support for a
proto.to_any()function, so we can create schema agnostic protobuf messages with Skycfg.