Drop gogo support #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathleen-stripe
requested changes
Aug 17, 2021
README.md
Outdated
| creates will handle the conversion of these types. | ||
| Skycfg has dropped support for | ||
| [gogo/protobuf](https://github.com/gogo/protobuf), an alternative protobuf go | ||
| code generator, when upgrading to using the go-protobuf v2 `pi. For using gogo |
There was a problem hiding this comment.
nit: typo in "`pi" - I'm assuming that's supposed to be "api."
|
Nice, great catch |
kathleen-stripe
approved these changes
Aug 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes gogo support from Skycfg
In moving to the new go protobuf v2 api, Skycfg will only be able to expose the types in a provided
protoregsitry.Types, which accepts values https://pkg.go.dev/google.golang.org/protobuf/reflect/protoregistry#Types.RegisterMessage that implement https://pkg.go.dev/google.golang.org/protobuf@v1.27.1/reflect/protoreflect#MessageType.However, https://github.com/gogo/protobuf (an alternative go code generator that Skycfg supported) does not support the new API (implementing MessageType and other interfaces). As we move Skycfg to using the new protobuf api, I don't see a way to support gogo and thus this PR drops it.
For any user interested in using Skycfg with gogo, Skycfg was tagged with
v0.1.0prior to the v2 api switch, and users can continue to use that version with gogo support, but with the old protobuf api.Testing
I ran bazel build, test and go build on skycfg and everything compiles (after removing the gogo tests)