Rename isFlowController to canShowWalletsInline. (#9666)

stripe · Nov 19, 2024 · 3c441cb · 3c441cb
1 parent dcb4edb
commit 3c441cb
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/...ava/com/stripe/android/paymentsheet/verticalmode/PaymentMethodVerticalLayoutInteractor.kt b/...ava/com/stripe/android/paymentsheet/verticalmode/PaymentMethodVerticalLayoutInteractor.kt
@@ -80,7 +80,7 @@ internal class DefaultPaymentMethodVerticalLayoutInteractor(
     private val onEditPaymentMethod: (DisplayableSavedPaymentMethod) -> Unit,
     private val onSelectSavedPaymentMethod: (PaymentMethod) -> Unit,
     private val walletsState: StateFlow<WalletsState?>,
-    private val isFlowController: Boolean,
+    private val canShowWalletsInline: Boolean,
     private val onMandateTextUpdated: (ResolvableString?) -> Unit,
     private val updateSelection: (PaymentSelection?) -> Unit,
     private val isCurrentScreen: StateFlow<Boolean>,
@@ -162,7 +162,7 @@ internal class DefaultPaymentMethodVerticalLayoutInteractor(
                 },
                 onUpdatePaymentMethod = { viewModel.savedPaymentMethodMutator.updatePaymentMethod(it) },
                 walletsState = viewModel.walletsState,
-                isFlowController = !viewModel.isCompleteFlow,
+                canShowWalletsInline = !viewModel.isCompleteFlow,
                 updateSelection = viewModel::updateSelection,
                 isCurrentScreen = viewModel.navigationHandler.currentScreen.mapAsStateFlow {
                     it is PaymentSheetScreen.VerticalMode
@@ -319,7 +319,7 @@ internal class DefaultPaymentMethodVerticalLayoutInteractor(
     }
 
     private fun showsWalletsInline(walletsState: WalletsState?): Boolean {
-        return isFlowController && walletsState != null && walletsState.googlePay != null
+        return canShowWalletsInline && walletsState != null && walletsState.googlePay != null
     }
 
     private fun getDisplayedSavedPaymentMethod(

diff --git a/...ipe/android/paymentsheet/verticalmode/DefaultPaymentMethodVerticalLayoutInteractorTest.kt b/...ipe/android/paymentsheet/verticalmode/DefaultPaymentMethodVerticalLayoutInteractorTest.kt
@@ -450,7 +450,7 @@ class DefaultPaymentMethodVerticalLayoutInteractorTest {
                 paymentMethodTypes = listOf("card", "cashapp")
             )
         ),
-        isFlowController = false,
+        canShowWalletsInline = false,
     ) {
         walletsState.value = WalletsState(
             link = WalletsState.Link("email@email.com"),
@@ -481,7 +481,7 @@ class DefaultPaymentMethodVerticalLayoutInteractorTest {
                 paymentMethodTypes = listOf("card", "cashapp")
             )
         ),
-        isFlowController = true,
+        canShowWalletsInline = true,
     ) {
         walletsState.value = WalletsState(
             link = WalletsState.Link("email@email.com"),
@@ -515,7 +515,7 @@ class DefaultPaymentMethodVerticalLayoutInteractorTest {
                     paymentMethodTypes = listOf("card", "cashapp")
                 )
             ),
-            isFlowController = true,
+            canShowWalletsInline = true,
             updateSelection = { selectedWallet = it },
         ) {
             walletsState.value = WalletsState(
@@ -547,7 +547,7 @@ class DefaultPaymentMethodVerticalLayoutInteractorTest {
                 paymentMethodTypes = listOf("card", "cashapp")
             )
         ),
-        isFlowController = true,
+        canShowWalletsInline = true,
     ) {
         walletsState.value = WalletsState(
             link = WalletsState.Link("email@email.com"),
@@ -575,7 +575,7 @@ class DefaultPaymentMethodVerticalLayoutInteractorTest {
                 paymentMethodTypes = listOf("card", "cashapp")
             )
         ),
-        isFlowController = true,
+        canShowWalletsInline = true,
     ) {
         walletsState.value = WalletsState(
             link = null,
@@ -988,7 +988,7 @@ class DefaultPaymentMethodVerticalLayoutInteractorTest {
         onEditPaymentMethod: (DisplayableSavedPaymentMethod) -> Unit = { notImplemented() },
         onSelectSavedPaymentMethod: (PaymentMethod) -> Unit = { notImplemented() },
         onUpdatePaymentMethod: (DisplayableSavedPaymentMethod) -> Unit = { notImplemented() },
-        isFlowController: Boolean = false,
+        canShowWalletsInline: Boolean = false,
         updateSelection: (PaymentSelection?) -> Unit = { notImplemented() },
         onMandateTextUpdated: (ResolvableString?) -> Unit = { notImplemented() },
         reportPaymentMethodTypeSelected: (PaymentMethodCode) -> Unit = { notImplemented() },
@@ -1021,7 +1021,7 @@ class DefaultPaymentMethodVerticalLayoutInteractorTest {
             onEditPaymentMethod = onEditPaymentMethod,
             onSelectSavedPaymentMethod = onSelectSavedPaymentMethod,
             walletsState = walletsState,
-            isFlowController = isFlowController,
+            canShowWalletsInline = canShowWalletsInline,
             onMandateTextUpdated = onMandateTextUpdated,
             updateSelection = { paymentSelection ->
                 selection.value = paymentSelection