Propagate Result<T> to call-site

stripe · Jan 10, 2025 · 7855ff4 · 7855ff4
1 parent 132e90a
commit 7855ff4
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 19 deletions.
diff --git a/...src/main/java/com/stripe/android/financialconnections/domain/CreateInstantDebitsResult.kt b/...src/main/java/com/stripe/android/financialconnections/domain/CreateInstantDebitsResult.kt
@@ -61,15 +61,12 @@ internal class RealCreateInstantDebitsResult @Inject constructor(
         val incentiveEligibilitySessionId = elementsSessionContext?.incentiveEligibilitySession?.id
 
         val eligibleForIncentive = if (incentiveEligibilitySessionId != null) {
-            runCatching {
-                consumerRepository.updateAvailableIncentives(
-                    sessionId = incentiveEligibilitySessionId,
-                    consumerSessionClientSecret = clientSecret,
-                )
-            }.fold(
-                onSuccess = { it.data.isNotEmpty() },
-                onFailure = { false },
-            )
+            consumerRepository.updateAvailableIncentives(
+                sessionId = incentiveEligibilitySessionId,
+                consumerSessionClientSecret = clientSecret,
+            ).map {
+                it.data.isNotEmpty()
+            }.getOrDefault(false)
         } else {
             false
         }

diff --git a/.../android/financialconnections/repository/FinancialConnectionsConsumerSessionRepository.kt b/.../android/financialconnections/repository/FinancialConnectionsConsumerSessionRepository.kt
@@ -73,7 +73,7 @@ internal interface FinancialConnectionsConsumerSessionRepository {
     suspend fun updateAvailableIncentives(
         sessionId: String,
         consumerSessionClientSecret: String,
-    ): UpdateAvailableIncentives
+    ): Result<UpdateAvailableIncentives>
 
     companion object {
         operator fun invoke(
@@ -247,13 +247,13 @@ private class FinancialConnectionsConsumerSessionRepositoryImpl(
     override suspend fun updateAvailableIncentives(
         sessionId: String,
         consumerSessionClientSecret: String,
-    ): UpdateAvailableIncentives {
+    ): Result<UpdateAvailableIncentives> {
         return consumersApiService.updateAvailableIncentives(
             sessionId = sessionId,
             consumerSessionClientSecret = consumerSessionClientSecret,
             requestSurface = requestSurface,
             requestOptions = provideApiRequestOptions(useConsumerPublishableKey = true),
-        ).getOrThrow()
+        )
     }
 
     private suspend fun postConsumerSession(

diff --git a/.../java/com/stripe/android/financialconnections/domain/RealCreateInstantDebitsResultTest.kt b/.../java/com/stripe/android/financialconnections/domain/RealCreateInstantDebitsResultTest.kt
@@ -221,13 +221,15 @@ class RealCreateInstantDebitsResultTest {
                 consumerSessionClientSecret = eq("clientSecret"),
             )
         ).thenReturn(
-            UpdateAvailableIncentives(
-                data = listOf(
-                    LinkConsumerIncentive(
-                        incentiveParams = LinkConsumerIncentive.IncentiveParams(
-                            paymentMethod = "link_instant_debits",
-                        ),
-                        incentiveDisplayText = "$5",
+            Result.success(
+                UpdateAvailableIncentives(
+                    data = listOf(
+                        LinkConsumerIncentive(
+                            incentiveParams = LinkConsumerIncentive.IncentiveParams(
+                                paymentMethod = "link_instant_debits",
+                            ),
+                            incentiveDisplayText = "$5",
+                        )
                     )
                 )
             )