Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActivityOnResult is not called after ConfirmSetupIntent in Fragments with 3dSecure Validation #1311

Closed
SergioDim3nsions opened this issue Aug 6, 2019 · 4 comments · Fixed by #1316
Assignees
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@SergioDim3nsions
Copy link

Summary

I am trying confirm the setupIntent with a test card "4000 000 000 3220" for add a payment method.

For card without 3dSecure works fine the ActivityOnResult with fragment context.
with Activity context work in all cases.

Example Code:
stripe.confirmSetupIntent(fragment, confirmSetupIntentParams)

Android version

Version 8.0.0

Impacted devices

Samsung Galaxy S8

Installation method

Gradle with android studio

SDK version

The new version released 10.2.0

@mshafrir-stripe
Copy link
Collaborator

@SergioDim3nsions thanks for filing, I'll look into this today

@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Aug 6, 2019
@mshafrir-stripe mshafrir-stripe self-assigned this Aug 6, 2019
mshafrir-stripe added a commit that referenced this issue Aug 6, 2019
This method was missing a call to `setPaymentMethodCreateParams()`.

Fixes #1311
@mshafrir-stripe
Copy link
Collaborator

@SergioDim3nsions I found what was causing your issue, and fixed it in PR #1316. This should be available in the next release. Thanks for reporting.

mshafrir-stripe added a commit that referenced this issue Aug 6, 2019
This method was missing a call to `setPaymentMethodCreateParams()`.

Fixes #1311
mshafrir-stripe added a commit that referenced this issue Aug 6, 2019
This method was missing a call to `setPaymentMethodCreateParams()`.

Fixes #1311
mshafrir-stripe added a commit that referenced this issue Aug 6, 2019
This method was missing a call to `setPaymentMethodCreateParams()`.

Fixes #1311
@mshafrir-stripe
Copy link
Collaborator

I just published 10.2.1, which includes this fix

@SergioDim3nsions
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants