Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RTL CardInputWidget error with CVC field #2852

Closed
jakeaaron opened this issue Sep 15, 2020 · 2 comments · Fixed by #2873
Closed

RTL CardInputWidget error with CVC field #2852

jakeaaron opened this issue Sep 15, 2020 · 2 comments · Fixed by #2873
Assignees
@mshafrir-stripe
Labels
triaged Issue has been reviewed by Stripe and is being tracked internally

Comments

@jakeaaron
Copy link

using sdk version 14.5.0, running Android 11 on emulator:

CVC field is overlapping card field using CardInputWidget in a RTL language (arabic, for instance).

Screenshot_1600184220
@mshafrir-stripe mshafrir-stripe added the triaged Issue has been reviewed by Stripe and is being tracked internally label Sep 21, 2020
@mshafrir-stripe mshafrir-stripe self-assigned this Sep 21, 2020
@mshafrir-stripe
Copy link
Collaborator

@jakeaaron thanks for filing, we'll have this fixed for the upcoming release

mshafrir-stripe added a commit that referenced this issue Sep 21, 2020
@mshafrir-stripe
Add RTL support to card widgets
0156f13 
Use `start` instead of `left` and `end` instead of `right`.

Fixes #2852
@mshafrir-stripe mshafrir-stripe mentioned this issue Sep 21, 2020
Merged
@jakeaaron
Copy link
Author

Great, thanks @mshafrir-stripe !

mshafrir-stripe added a commit that referenced this issue Sep 21, 2020
@mshafrir-stripe
Add RTL support to card widgets (#2873)
8979b71 
Use `start` instead of `left` and `end` instead of `right`.

Fixes #2852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mshafrir-stripe mshafrir-stripe

Labels
triaged Issue has been reviewed by Stripe and is being tracked internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RTL support to card widgets stripe/stripe-android
2 participants
@jakeaaron @mshafrir-stripe