Refactor session complete payment #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
requested changes
Jun 7, 2019
| @@ -315,7 +318,7 @@ private void processPaymentIntent(@NonNull PaymentIntent paymentIntent) { | |||
| confirmPaymentIntent(Objects.requireNonNull(paymentIntent.getId())); | |||
| return; | |||
| } | |||
|
|
|||
| mPaymentSession.onCompleted(); | |||
There was a problem hiding this comment.
Are there states the PaymentIntent can be in where we shouldn't call onCompleted? In other words, should we only do this if PaymentIntent's status is succeeded? Also, should we move this call into finishPayment()?
mshafrir-stripe
requested changes
Jun 11, 2019
build.gradle
Outdated
| @@ -18,6 +18,7 @@ allprojects { | |||
| repositories { | |||
| google() | |||
| jcenter() | |||
| mavenLocal() | |||
| @@ -26,7 +26,7 @@ | |||
| * You can get your key here: https://dashboard.stripe.com/account/apikeys | |||
| */ | |||
| private static final String PUBLISHABLE_KEY = | |||
| "put your key here"; | |||
| "pk_test_pWjWlOKXD13QQ1o31awb0IM000u9Xq3Hxd"; | |||
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| // Put your Base URL here. Unless you customized it, the URL will be something like | |||
| // https://hidden-beach-12345.herokuapp.com/ | |||
| private static final String BASE_URL = "put your url here"; | |||
| private static final String BASE_URL = "https://jemerick-stripe-3ds2.herokuapp.com/"; | |||
mshafrir-stripe
requested changes
Jun 11, 2019
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| // Put your Base URL here. Unless you customized it, the URL will be something like | |||
| // https://hidden-beach-12345.herokuapp.com/ | |||
| private static final String BASE_URL = "put your base url here"; | |||
| private static final String BASE_URL = "https://jemerick-stripe-3ds2.herokuapp.com/"; | |||
| @@ -40,7 +40,7 @@ | |||
| * You can get your key here: https://dashboard.stripe.com/account/apikeys | |||
| */ | |||
| private static final String PUBLISHABLE_KEY = | |||
| "put your publishable key here"; | |||
| "pk_test_pWjWlOKXD13QQ1o31awb0IM000u9Xq3Hxd"; | |||
| */ | ||
| public void completePayment(@NonNull PaymentCompletionProvider provider) { |
There was a problem hiding this comment.
I wonder if we still need to call onPaymentSessionDataChanged()? Probably not because this is not an async task, but worth calling out.
This reverts commit 4517aa9.
mshafrir-stripe
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removed payment completion provider and payment result listener.
Also fixed a few bugs with the totals in the sample store app.
Motivation
MOBILE3DS2-382
Confusion around the usage of paymentSession.completePayment.
Testing
Automated tests, sample store app.