Make AppInfo public #1132
Closed
Make AppInfo public #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making AppInfo & AppInfo create methods public to allow 3rd party plugins (e.g. tipsi-stripe) to be updated so that they can start providing user-agent information. Fixes stripe#1131
|
Thanks for submitting the PR. I ended up implementing it myself before seeing yours in #1133. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Making AppInfo & AppInfo create methods public to allow 3rd party plugins (e.g. tipsi-stripe) to be updated so that they can start providing plugin information. Fixes #1131
Motivation
We are working on upgrading tipsi-stripe so that it will start providing plugin information to Stripe, and we need to be able to call
stripe.setAppInfo(AppInfo.create(...)), which requiresAppInfoto be public so that it can be imported and thecreatemethods to be public so that they can be invoked.Testing
Build passed (if any additional testing beyond this is needed please let me know!)