Support "intent://" URIs in payment auth WebView #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
force-pushed
the
webview-intent-uri
branch
2 times, most recently
from
1681325 to
c283259
Compare
`intent://` URIs need to first be parsed into `Intent` objects, then handled.
mshafrir-stripe
force-pushed
the
webview-intent-uri
branch
from
c283259 to
1ce8b53
Compare
stripe/src/test/java/com/stripe/android/view/PaymentAuthWebViewTest.java
Outdated
Show resolved
Hide resolved
stripe/src/test/java/com/stripe/android/view/PaymentAuthWebViewTest.java
Outdated
Show resolved
Hide resolved
karlr-stripe
requested changes
Sep 12, 2019
karlr-stripe
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
intent://URIs need to first be parsed intoIntentobjects, then handled.
Motivation
ANDROID-409
Testing
Unit and manual testing