Add support for idempotency key on Stripe token API requests #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfi-stripe
approved these changes
Nov 1, 2019
| * @param callback a [ApiResultCallback] to receive the result or error | ||
| */ | ||
| @UiThread | ||
| fun createToken(card: Card, callback: ApiResultCallback<Token>) { | ||
| @JvmOverloads | ||
| fun createToken( |
There was a problem hiding this comment.
Out of curiosity... how does @jvmoverloads work for a function like this, where the 2nd arg is optional -- but the 3rd is not? Does a Java caller always need to specify idempotencyKey since it is positionally before a non optional argument?
There was a problem hiding this comment.
@markfi-stripe good question. I verified that it works as intended - idempotencyKey becomes optional.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See Idempotent Requests
Motivation
Fixes #1025
Testing
Wrote integration tests