Update configuration of example app #1871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary - Add logic to read configuration settings from local `gradle.properties` or environment variables and write out to `AndroidManifest.xml` at build time. - Update `Settings` to be a class that takes a `Context` to read metadata from `AndroidManifest.xml`. Retain constants in `Settings` to preserve existing functionality. - Update `RetrofitFactory` accordingly. Motivation Enable Espresso testing of the example app without hardcoding config values by setting them in Travis environment variables [0]. [0] https://docs.travis-ci.com/user/environment-variables/
chander-stripe
approved these changes
Nov 25, 2019
stripe-ci
assigned mshafrir-stripe and unassigned felipecsl-stripe, chander-stripe and markfi-stripe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
gradle.propertiesor environment variables and write outto
AndroidManifest.xmlat build time.Settingsto be a class that takes aContextto read metadata from
AndroidManifest.xml.Retain constants in
Settingsto preserve existingfunctionality.
RetrofitFactoryaccordingly.Motivation
Enable Espresso testing of the example app without
hardcoding config values by setting them in Travis
environment variables [0].
[0] https://docs.travis-ci.com/user/environment-variables/