Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SourceParams fields #2028

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Update SourceParams fields #2028

merged 1 commit into from
Jan 7, 2020

Conversation

mshafrir-stripe
Copy link
Collaborator

  • Update setOwner() to take OwnerParams instead of Map
  • Remove setRedirect(), use setReturnUrl() instead
  • Update some setters to take null values, simplifying usage
  • Update comments

@mshafrir-stripe
Update SourceParams fields
c0559d9 
- Update `setOwner()` to take `OwnerParams` instead of `Map`
- Remove `setRedirect()`, use `setReturnUrl()` instead
- Update some setters to take null values, simplifying usage
- Update comments
@mshafrir-stripe mshafrir-stripe merged commit 44341dd into master Jan 7, 2020
@mshafrir-stripe mshafrir-stripe deleted the source-params-update branch January 7, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chander-stripe chander-stripe chander-stripe approved these changes

Assignees

@mshafrir-stripe mshafrir-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mshafrir-stripe @chander-stripe @stripe-ci @csabol-stripe @davidme-stripe @markfi-stripe