Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PaymentMethodOptions and PaymentIntent CVC recollection #2040

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

mshafrir-stripe
Copy link
Collaborator

Summary

  • Add PaymentMethodOptionsParams sealed class and
    PaymentMethodOptionsParams.Card subclass
  • Update ConfirmPaymentIntentParams.createWithPaymentMethodId()
    with optional PaymentMethodOptionsParams? argument

Motivation

Enable users to recollect and update the CVC of a card payment method
when confirming a PaymentIntent

ANDROID-464

Testing

Added unit tests + verified manually end to end

Summary
- Add `PaymentMethodOptionsParams` sealed class and
  `PaymentMethodOptionsParams.Card` subclass
- Update `ConfirmPaymentIntentParams.createWithPaymentMethodId()`
  with optional `PaymentMethodOptionsParams?` argument

Motivation
Enable users to recollect and update the CVC of a card payment method
when confirming a `PaymentIntent`

ANDROID-464

Testing
Added unit tests + verified manually end to end
Copy link

@bendong-stripe bendong-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API usage looks good to me

@mshafrir-stripe mshafrir-stripe merged commit 71458c0 into master Jan 10, 2020
@mshafrir-stripe mshafrir-stripe deleted the pm-opts branch January 10, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants