Simplify PaymentSession state and lifecycle management #2165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary - Create `PaymentSessionViewModel` and integrate in `PaymentSession` - Remove `savedInstanceState` argument from `PaymentSession#init()` - Remove `PaymentSession#savePaymentSessionInstanceState()` - Remove `PaymentSession#onDestroy()` - the `listener` instance is now released automatically - In `PaymentSession#init()`, immediately call the `listener` when `shouldPrefetchCustomer` is false - Move `CustomerSession` initialization in example app to `Application` subclass Motivation Simplify `PaymentSession` state management and API. It is no longer necessary to pass a state `Bundle` and manage lifecycle events. Testing Add unit tests Manually verify with both `Activity` and `Fragment`
chander-stripe
approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PaymentSessionViewModeland integrate inPaymentSessionsavedInstanceStateargument fromPaymentSession#init()PaymentSession#savePaymentSessionInstanceState()PaymentSession#onDestroy()- thelistenerinstanceis now released automatically
PaymentSession#init(), immediately call thelistenerwhenshouldPrefetchCustomeris falseCustomerSessioninitialization in example app toApplicationsubclassMotivation
Simplify
PaymentSessionstate management and API. It isno longer necessary to pass a state
Bundleand managelifecycle events.
Testing
Add unit tests
Manually verify with both
ActivityandFragment