Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CardFunding enum #2185

Merged
merged 1 commit into from
Feb 18, 2020
Merged

Create CardFunding enum #2185

merged 1 commit into from
Feb 18, 2020

Conversation

mshafrir-stripe
Copy link
Collaborator

Summary

Convert Card.FundingType @StringDef to an enum

Motivation

Simplify logic and reuse in a future PR

@mshafrir-stripe
Create CardFunding enum
01bbe46 
Convert `Card.FundingType` `@StringDef` to an enum

Simplify logic and reuse in a future PR
markfi-stripe
markfi-stripe approved these changes Feb 18, 2020
View reviewed changes
Copy link

@markfi-stripe markfi-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 other than 1 question

stripe/src/main/java/com/stripe/android/model/CardFunding.kt Show resolved Hide resolved
@mshafrir-stripe mshafrir-stripe merged commit c504a34 into master Feb 18, 2020
@mshafrir-stripe mshafrir-stripe deleted the card-funding-enum branch February 18, 2020 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markfi-stripe markfi-stripe markfi-stripe approved these changes

Assignees

@mshafrir-stripe mshafrir-stripe

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mshafrir-stripe @markfi-stripe @stripe-ci @chander-stripe