Allow CardMultilineWidget's TextInputLayout's to be styled #2646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
requested changes
Jul 16, 2020
stripe/res/values/styles.xml
Outdated
| </style> | ||
|
|
||
| <style name="Stripe.CardMultilineWidget.TextInputLayout" | ||
| parent="Stripe.Base.CardInputWidget.TextInputLayout" /> |
There was a problem hiding this comment.
Should this be Stripe.Base.CardMultilineWidget.TextInputLayout?
There was a problem hiding this comment.
whoops, good catch.
|
I wonder if we should create an entry in the example app to show styling of our widgets? |
Yeah, that would be cool. Now that you mention that though, I realized there probably isn't a way to scope this to a single activity/view. Since we're referencing a style directly, as soon as you create a style with that name, it will be used for all instances of the widget. May still need more thought here, though this patch is still strictly better than what we had before |
mshafrir-stripe
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Introduce a base style
Stripe.Base.CardMultilineWidget.TextInputLayout, andoverride it with
Stripe.CardMultilineWidget.TextInputLayoutto allow foruser customization.
This is similar to #2002
Motivation
Fixes #2628
Testing
Tested manually