Deprecate metadata field on retrieved API objects #2704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshafrir-stripe
requested changes
Aug 13, 2020
| */ | ||
| @Deprecated("Metadata is no longer returned to clients using publishable keys. Retrieve them on your server using you secret key instead.") |
There was a problem hiding this comment.
"on your backend" vs "on your server"? Not sure the preferred wording.
"your secret" instead of "you secret"
There was a problem hiding this comment.
oh good catch. I literally just copy-pasted this from iOS so it will need to be updated there as well cc @csabol-stripe.
Don't have a strong opinion on backend vs server
| */ | ||
| @Deprecated("Metadata is no longer returned to clients using publishable keys. Retrieve them on your server using you secret key instead.") |
There was a problem hiding this comment.
see other comment
mshafrir-stripe
previously approved these changes
Aug 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deprecates the
metadatafield inSource,PaymentMethod, andCard.Motivation
This field is now only accessible via secret key due to security concerns. Clients never have access to a secret key so we cannot make use of this field.
Testing