Re-render shipping methods screen when shipping methods change #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PagerAdapter` does not automatically recreate the views for its items when `notifyDataSetChanged()` is called. Instead, mark the shipping methods view as no longer valid in `getItemPosition()`
mshafrir-stripe
requested review from
aliriaz-stripe,
chander-stripe and
pardo-stripe
chander-stripe
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PagerAdapterdoes not automatically recreate the views for its itemswhen
notifyDataSetChanged()is called. Instead, mark the shippingmethods view as no longer valid in
getItemPosition().Motivation
Fix issue where only the first result from
ShippingMethodsFactory#create()is rendered.
Testing