Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null client_secret in result Intent #2989

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

mshafrir-stripe
Copy link
Collaborator

If a client_secret cannot be retrieved from the result Intent,
call callback.onError() instead of throwing an exception.

Fixes #2986

If a `client_secret` cannot be retrieved from the result Intent,
call `callback.onError()` instead of throwing an exception.

Fixes #2986
Copy link

@pardo-stripe pardo-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mshafrir-stripe mshafrir-stripe merged commit ce5be31 into master Oct 29, 2020
@mshafrir-stripe mshafrir-stripe deleted the pc-null-client-secret branch October 29, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StripePaymentController handlePaymentResult
2 participants