Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark some builders in PaymentMethodCreateParams as deprecated #3088

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Mark some builders in PaymentMethodCreateParams as deprecated #3088

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions stripe/src/main/java/com/stripe/android/model/PaymentMethodCreateParams.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,12 +280,13 @@ data class PaymentMethodCreateParams internal constructor(

@Parcelize
data class Ideal(
private val bank: String?
var bank: String?
) : StripeParamsModel, Parcelable {
override fun toParamMap(): Map<String, Any> {
return bank?.let { mapOf(PARAM_BANK to it) }.orEmpty()
}

@Deprecated("Ideal#bank is now visible and mutable.")
class Builder : ObjectBuilder<Ideal> {
internal var bank: String? = null

Expand All @@ -305,14 +306,15 @@ data class PaymentMethodCreateParams internal constructor(

@Parcelize
data class Fpx(
private val bank: String?
var bank: String?
) : StripeParamsModel, Parcelable {
override fun toParamMap(): Map<String, Any> {
return bank?.let {
mapOf(PARAM_BANK to it)
}.orEmpty()
}

@Deprecated("Fpx#bank is now visible and mutable.")
class Builder : ObjectBuilder<Fpx> {
internal var bank: String? = null

Expand Down Expand Up @@ -347,14 +349,15 @@ data class PaymentMethodCreateParams internal constructor(

@Parcelize
data class SepaDebit(
private val iban: String?
var iban: String?
) : StripeParamsModel, Parcelable {
override fun toParamMap(): Map<String, Any> {
return iban?.let {
mapOf(PARAM_IBAN to it)
}.orEmpty()
}

@Deprecated("SepaDebit#iban is now visible and mutable.")
class Builder : ObjectBuilder<SepaDebit> {
private var iban: String? = null

Expand Down