Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tint flicker in CardBrandView #3456

Merged
merged 1 commit into from
Mar 11, 2021
Merged

Fix tint flicker in CardBrandView #3456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions stripe/src/main/java/com/stripe/android/view/CardBrandView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import android.view.LayoutInflater
import android.widget.FrameLayout
import androidx.annotation.ColorInt
import androidx.core.graphics.drawable.DrawableCompat
import androidx.core.view.doOnNextLayout
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extensions are great!

import com.stripe.android.databinding.CardBrandViewBinding
import com.stripe.android.model.CardBrand
import kotlin.properties.Delegates
Expand Down Expand Up @@ -66,12 +67,10 @@ internal class CardBrandView @JvmOverloads constructor(
init {
isClickable = false
isFocusable = false
}

override fun onWindowFocusChanged(hasWindowFocus: Boolean) {
super.onWindowFocusChanged(hasWindowFocus)
// needed to tint CardBrand.Unknown icon
updateIcon()
doOnNextLayout {
updateIcon()
}
}

private fun updateIcon() {
Expand Down