Fix Google Pay support for Connect accounts #3752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
ccen-stripe,
michelleb-stripe and
mshafrir-stripe
as code owners
brnunes-stripe
assigned brnunes-stripe, mshafrir-stripe, michelleb-stripe and ccen-stripe and unassigned brnunes-stripe
stripe/src/test/java/com/stripe/android/googlepay/StripeGooglePayViewModelTest.kt
Outdated
Show resolved
Hide resolved
stripe/src/test/java/com/stripe/android/googlepay/StripeGooglePayViewModelTest.kt
Outdated
Show resolved
Hide resolved
mshafrir-stripe
previously approved these changes
May 24, 2021
michelleb-stripe
suggested changes
May 24, 2021
stripe/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
michelleb-stripe
previously approved these changes
May 24, 2021
brnunes-stripe
dismissed stale reviews from michelleb-stripe and mshafrir-stripe
via
dbb5c77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Include
stripeAccountIdin request to create PaymentMethod from Google Pay token.Log error and show default error message if Google Pay processing failed without a
googlePayStatus.Motivation
Account id was not added in request, so payment would fail because the PaymentMethod was not assigned to the Connect account.
Testing