Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PaymentSheet support for Jetpack Compose #3892

Merged
merged 11 commits into from
Jun 30, 2021
Merged

PaymentSheet support for Jetpack Compose #3892

merged 11 commits into from
Jun 30, 2021

Conversation

michelleb-stripe
Copy link
Contributor

@michelleb-stripe michelleb-stripe commented Jun 28, 2021 •
edited
Loading

Summary

Allowing users to use the registerForActivityResult to launch the PaymentSheet Complete activity. This is important because in jetpack compose there is no activity accessible.

  • Modify the parameters of the PaymentSheet contract to keep it simple before exposing it.
  • The sessionId was removed because it is no longer used.
  • We will continue to support setting the color of the statusBar when the PaymentSheet activity interface is used, but will not support it in Jetpack Compose because it's use is generally set indirectly through the theme colors. Setting it in compose requires extra libraries.

Motivation

#3803

Testing

  • Added tests
  • Modified tests
  • Manually verified

@michelleb-stripe michelleb-stripe changed the title PaymentSheet support for Jetpack Compose [WIP] PaymentSheet support for Jetpack Compose Jun 28, 2021
@github-actions
Copy link
Contributor

Diffuse output:

@michelleb-stripe michelleb-stripe changed the title [WIP] PaymentSheet support for Jetpack Compose PaymentSheet support for Jetpack Compose Jun 29, 2021
@michelleb-stripe michelleb-stripe merged commit 15dc285 into master Jun 30, 2021
@michelleb-stripe michelleb-stripe deleted the michelleb/3803-compose-integration branch June 30, 2021 00:34
michelleb-stripe added a commit that referenced this pull request Jul 2, 2021
@michelleb-stripe
PaymentSheet support for Jetpack Compose (#3892)
223a680
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshafrir-stripe mshafrir-stripe mshafrir-stripe approved these changes

@brnunes-stripe brnunes-stripe Awaiting requested review from brnunes-stripe

@ccen-stripe ccen-stripe Awaiting requested review from ccen-stripe

Assignees

@michelleb-stripe michelleb-stripe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michelleb-stripe @mshafrir-stripe @yuki-stripe @brnunes-stripe @ccen-stripe