Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser redirect on firefox browser. #4046

Merged
merged 2 commits into from
Jul 27, 2021
Merged

Fix browser redirect on firefox browser. #4046

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be5e7b4
Make the StripeBrowserLauncherActivity a single instance so that it c…
michelleb-stripe Jul 25, 2021
3be26ec
Switch to singleTask
michelleb-stripe Jul 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions payments-core/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
<activity
android:name=".payments.StripeBrowserLauncherActivity"
android:theme="@style/StripeTransparentTheme"
android:launchMode="singleTop"
android:launchMode="singleTask"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to singleTask

Copy link
Collaborator

@mshafrir-stripe mshafrir-stripe Jul 27, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't have to be in this PR, but would be nice to add a comment as to why this is necessary.

android:exported="true">
<intent-filter>
<action android:name="android.intent.action.VIEW" />
Expand Down Expand Up @@ -93,4 +93,4 @@
<package android:name="com.android.chrome" />
</queries>

</manifest>
</manifest>