Use GooglePayPaymentMethodLauncher in Payment Sheet custom flow
#4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brnunes-stripe
requested review from
ccen-stripe,
michelleb-stripe and
mshafrir-stripe
as code owners
brnunes-stripe
commented
Aug 17, 2021
Comment on lines
32
to
+36
| private val readyCallback: ReadyCallback, | ||
| private val activityResultLauncher: ActivityResultLauncher<GooglePayLauncherContract.Args>, | ||
| private val googlePayRepositoryFactory: (GooglePayEnvironment) -> GooglePayRepository, | ||
| analyticsRequestFactory: AnalyticsRequestFactory, | ||
| analyticsRequestExecutor: AnalyticsRequestExecutor = DefaultAnalyticsRequestExecutor() | ||
| analyticsRequestExecutor: AnalyticsRequestExecutor |
There was a problem hiding this comment.
Just reordering to match the order of GooglePayPaymentMethodLauncher, no changes to public API.
michelleb-stripe
approved these changes
Aug 17, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate from old
StripeGooglePayContractto newGooglePayPaymentMethodLauncherContractwhich is public.Motivation
Remove dependency on internal classes.
Support Google Pay for Setup Intents on Payment Sheet custom flow.
Testing