Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove global length and CA postal restriction #4122

Merged
merged 2 commits into from
Aug 20, 2021

Conversation

michelleb-stripe
Copy link
Contributor

Summary

Remove global length and CA postal restrictions as any required checks will also happen server side.

Motivation

Fixes #4089

Testing

  • Added tests
  • Modified tests
  • Manually verified

@michelleb-stripe michelleb-stripe changed the title Remove global length and CA postal restriction [WIP] Remove global length and CA postal restriction Aug 20, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 20, 2021

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │           compressed           │          uncompressed          
          ├───────────┬───────────┬────────┼───────────┬───────────┬────────
 APK      │ old       │ new       │ diff   │ old       │ new       │ diff   
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
      dex │  11.5 MiB │  11.5 MiB │ -222 B │  39.1 MiB │  39.1 MiB │ -216 B 
     arsc │   1.3 MiB │   1.3 MiB │    0 B │   1.3 MiB │   1.3 MiB │    0 B 
 manifest │   2.5 KiB │   2.5 KiB │    0 B │  10.5 KiB │  10.5 KiB │    0 B 
      res │ 701.5 KiB │ 701.5 KiB │    0 B │     1 MiB │     1 MiB │    0 B 
    asset │  77.6 KiB │  77.6 KiB │   +1 B │ 109.1 KiB │ 109.1 KiB │   +1 B 
    other │    78 KiB │    78 KiB │   +2 B │   154 KiB │   154 KiB │    0 B 
──────────┼───────────┼───────────┼────────┼───────────┼───────────┼────────
    total │  13.7 MiB │  13.7 MiB │ -219 B │  41.8 MiB │  41.8 MiB │ -215 B 


         │          raw           │            unique            
         ├────────┬────────┬──────┼────────┬────────┬────────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff       
─────────┼────────┼────────┼──────┼────────┼────────┼────────────
   files │      3 │      3 │    0 │        │        │            
 strings │ 177957 │ 177955 │   -2 │ 165252 │ 165250 │ -2 (+2 -4) 
   types │  31289 │  31289 │    0 │  29740 │  29740 │  0 (+0 -0) 
 classes │  27457 │  27457 │    0 │  27457 │  27457 │  0 (+0 -0) 
 methods │ 158137 │ 158137 │    0 │ 154016 │ 154016 │  0 (+0 -0) 
  fields │ 108092 │ 108091 │   -1 │ 107790 │ 107789 │ -1 (+0 -1) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  293 │  293 │  0   
 entries │ 4332 │ 4332 │  0
APK
    compressed    │   uncompressed    │                                                       
─────────┬────────┼──────────┬────────┤                                                       
 size    │ diff   │ size     │ diff   │ path                                                  
─────────┼────────┼──────────┼────────┼───────────────────────────────────────────────────────
 3.5 MiB │ -222 B │ 10.2 MiB │ -216 B │ ∆ classes2.dex                                        
   188 B │   +2 B │      6 B │    0 B │ ∆ META-INF/androidx.activity_activity-compose.version 
 5.4 KiB │   +1 B │  5.3 KiB │   +1 B │ ∆ assets/dexopt/baseline.prof                         
─────────┼────────┼──────────┼────────┼───────────────────────────────────────────────────────
 3.5 MiB │ -219 B │ 10.2 MiB │ -215 B │ (total)
DEX
STRINGS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   165252 │ 165250 │ -2 (+2 -4) 
  
  + �
  ���
  ��
  ���
  ���
  
  ���
  �������2�0�B���¢����R�����0�X�T¢��
  R����
   �*���0�0�X��¢��
  ¨��
  + SMAP
  PostalCodeEditText.kt
  Kotlin
  *S Kotlin
  *F
  + 1 PostalCodeEditText.kt
  com/stripe/android/view/PostalCodeEditText
  + 2 Delegates.kt
  kotlin/properties/Delegates
  + 3 TextView.kt
  androidx/core/widget/TextViewKt
  *L
  1#1,120:1
  33#2,3:121
  58#3,23:124
  93#3,3:147
  *S KotlinDebug
  *F
  + 1 PostalCodeEditText.kt
  com/stripe/android/view/PostalCodeEditText
  *L
  24#1:121,3
  48#1:124,23
  48#1:147,3
  *E
  
  
  - �
  ���
  ��
  ���
  ���
  ���
  ���
  �������2�0�B���¢����R�����0�X�T¢��
  R�����0�X�T¢��
  R����
   �*���0�0�X��¢��
  ¨�	
  - MAX_LENGTH_GLOBAL
  - SMAP
  PostalCodeEditText.kt
  Kotlin
  *S Kotlin
  *F
  + 1 PostalCodeEditText.kt
  com/stripe/android/view/PostalCodeEditText
  + 2 Delegates.kt
  kotlin/properties/Delegates
  + 3 TextView.kt
  androidx/core/widget/TextViewKt
  *L
  1#1,122:1
  33#2,3:123
  58#3,23:126
  93#3,3:149
  *S KotlinDebug
  *F
  + 1 PostalCodeEditText.kt
  com/stripe/android/view/PostalCodeEditText
  *L
  24#1:123,3
  48#1:126,23
  48#1:149,3
  *E
  
  - ^(?!.*[DFIOQU])[A-VXY][0-9][A-Z] ?[0-9][A-Z][0-9]_
  

FIELDS:

   old    │ new    │ diff       
  ────────┼────────┼────────────
   107790 │ 107789 │ -1 (+0 -1) 
  
  - com.stripe.android.view.PostalCodeEditText MAX_LENGTH_GLOBAL: int

@michelleb-stripe michelleb-stripe changed the title [WIP] Remove global length and CA postal restriction Remove global length and CA postal restriction Aug 20, 2021
@michelleb-stripe michelleb-stripe merged commit b493caf into master Aug 20, 2021
@michelleb-stripe michelleb-stripe deleted the michelleb/postal-validation branch August 20, 2021 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants