Migrate PaymentController to PaymentLauncher within PaymentSheet components. #4159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
payments-core/src/main/java/com/stripe/android/payments/PaymentFlowFailureMessageFactory.kt
Outdated
Show resolved
Hide resolved
skyler-stripe
changed the title
skyler-stripe
requested review from
brnunes-stripe,
ccen-stripe and
mshafrir-stripe
as code owners
ccen-stripe
suggested changes
Sep 2, 2021
paymentsheet/src/test/java/com/stripe/android/paymentsheet/PaymentSheetActivityTest.kt
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Show resolved
Hide resolved
paymentsheet/src/test/java/com/stripe/android/paymentsheet/PaymentSheetViewModelTest.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/test/java/com/stripe/android/paymentsheet/PaymentSheetViewModelTest.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/test/java/com/stripe/android/paymentsheet/PaymentSheetViewModelTest.kt
Outdated
Show resolved
Hide resolved
ccen-stripe
suggested changes
Sep 3, 2021
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
paymentsheet/src/main/java/com/stripe/android/paymentsheet/PaymentSheetViewModel.kt
Outdated
Show resolved
Hide resolved
ccen-stripe
approved these changes
Sep 3, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
PaymentLauncher is a more modern api that gives us a few advantages over PaymentController. PaymentLauncher is more simple to use as it does not require us to handle the interim flows with PaymentFlowProcessor. It also uses ActivityResultLauncher which gives us more reliable result callbacks over startActivityForResult/onActivityResult.
doc on this project
Testing
Recording