Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix address pre-populate on line 1 #4183

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Conversation

michelleb-stripe
Copy link
Contributor

Summary

When the address was provided in the configuration it was switching line 1 and line 2.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@github-actions
Copy link
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │  11.5 MiB │  11.5 MiB │ -1 B │  39.3 MiB │  39.3 MiB │  0 B 
     arsc │   1.3 MiB │   1.3 MiB │  0 B │   1.3 MiB │   1.3 MiB │  0 B 
 manifest │   2.5 KiB │   2.5 KiB │  0 B │  10.5 KiB │  10.5 KiB │  0 B 
      res │ 639.4 KiB │ 639.4 KiB │  0 B │ 997.8 KiB │ 997.8 KiB │  0 B 
    asset │  77.7 KiB │  77.7 KiB │ -1 B │ 109.2 KiB │ 109.2 KiB │ -1 B 
    other │    78 KiB │    78 KiB │ -4 B │   154 KiB │   154 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │  13.6 MiB │  13.6 MiB │ -6 B │  41.9 MiB │  41.9 MiB │ -1 B 


         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      3 │      3 │    0 │        │        │           
 strings │ 178906 │ 178906 │    0 │ 165792 │ 165792 │ 0 (+0 -0) 
   types │  31505 │  31505 │    0 │  29863 │  29863 │ 0 (+0 -0) 
 classes │  27573 │  27573 │    0 │  27573 │  27573 │ 0 (+0 -0) 
 methods │ 159136 │ 159136 │    0 │ 154818 │ 154818 │ 0 (+0 -0) 
  fields │ 108402 │ 108402 │    0 │ 108051 │ 108051 │ 0 (+0 -0) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  293 │  293 │  0   
 entries │ 4326 │ 4326 │  0
APK
   compressed   │  uncompressed   │                                                       
─────────┬──────┼──────────┬──────┤                                                       
 size    │ diff │ size     │ diff │ path                                                  
─────────┼──────┼──────────┼──────┼───────────────────────────────────────────────────────
   186 B │ -4 B │      6 B │  0 B │ ∆ META-INF/androidx.activity_activity-compose.version 
 5.5 KiB │ -1 B │  5.3 KiB │ -1 B │ ∆ assets/dexopt/baseline.prof                         
 3.5 MiB │ -1 B │ 10.1 MiB │  0 B │ ∆ classes2.dex                                        
─────────┼──────┼──────────┼──────┼───────────────────────────────────────────────────────
 3.5 MiB │ -6 B │ 10.1 MiB │ -1 B │ (total)

@michelleb-stripe michelleb-stripe merged commit 7ef81af into master Sep 10, 2021
@michelleb-stripe michelleb-stripe deleted the michelleb/address-line branch September 10, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants