Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics event for failure creating 3ds2 params #4281

Merged
merged 1 commit into from
Oct 12, 2021

Conversation

brnunes-stripe
Copy link
Contributor

@brnunes-stripe brnunes-stripe commented Oct 11, 2021

Summary

Add analytics event for failure creating 3ds2 params.

Motivation

Missing event for when we are unable to construct an request.

Testing

  • Added tests
  • Modified tests
  • Manually verified
    Manually made the Stripe3ds2Fingerprint instantiation fail, verified the new event is logged.

@brnunes-stripe brnunes-stripe changed the title [WIP] Add analytics event for failure creating 3ds2 params Add analytics event for failure creating 3ds2 params Oct 12, 2021
Copy link
Contributor

@ccen-stripe ccen-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@brnunes-stripe brnunes-stripe merged commit 33aa7ef into master Oct 12, 2021
@brnunes-stripe brnunes-stripe deleted the brnunes/3ds2 branch October 12, 2021 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants