Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add extra height to CardMultilineWidget textboxes #4295

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

skyler-stripe
Copy link
Contributor

@skyler-stripe skyler-stripe commented Oct 14, 2021

Summary

increase height of textboxes on CardMutlilineWidget from 48dp -> 50dp

Motivation

#4294

The PaymentMethodsActivityStarter uses a different style to what is in PaymentSheet. By adding the extra 2dp we have a layout that is acceptable for both from a UX perspective.

Testing

  • Added tests
  • Modified tests
  • Manually verified

Tested on several different emulators to verify text was not cut off.

Screenshots

Before After
paymentSheetBefore paymentSheetAfter
exampleBefore exampleAfter

@github-actions
Copy link
Contributor

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: none)
NEW: paymentsheet-example-release-pr.apk (signature: none)

          │          compressed          │           uncompressed           
          ├───────────┬───────────┬──────┼─────────────┬─────────────┬──────
 APK      │ old       │ new       │ diff │ old         │ new         │ diff 
──────────┼───────────┼───────────┼──────┼─────────────┼─────────────┼──────
      dex │  11.6 MiB │  11.6 MiB │  0 B │    39.4 MiB │    39.4 MiB │  0 B 
     arsc │   1.4 MiB │   1.4 MiB │  0 B │     1.4 MiB │     1.4 MiB │  0 B 
 manifest │   2.5 KiB │   2.5 KiB │  0 B │    10.5 KiB │    10.5 KiB │  0 B 
      res │ 641.6 KiB │ 641.6 KiB │  0 B │ 1,003.4 KiB │ 1,003.4 KiB │  0 B 
    asset │  77.7 KiB │  77.7 KiB │  0 B │   109.1 KiB │   109.1 KiB │  0 B 
    other │    78 KiB │    78 KiB │  0 B │     154 KiB │     154 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼─────────────┼─────────────┼──────
    total │  13.7 MiB │  13.7 MiB │  0 B │      42 MiB │      42 MiB │  0 B 


         │          raw           │           unique            
         ├────────┬────────┬──────┼────────┬────────┬───────────
 DEX     │ old    │ new    │ diff │ old    │ new    │ diff      
─────────┼────────┼────────┼──────┼────────┼────────┼───────────
   files │      3 │      3 │    0 │        │        │           
 strings │ 179369 │ 179369 │    0 │ 166193 │ 166193 │ 0 (+0 -0) 
   types │  31636 │  31636 │    0 │  29987 │  29987 │ 0 (+0 -0) 
 classes │  27693 │  27693 │    0 │  27693 │  27693 │ 0 (+0 -0) 
 methods │ 159860 │ 159860 │    0 │ 155523 │ 155523 │ 0 (+0 -0) 
  fields │ 108807 │ 108807 │    0 │ 108455 │ 108455 │ 0 (+0 -0) 


 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  292 │  292 │  0   
 entries │ 4347 │ 4347 │  0

Copy link
Contributor

@ccen-stripe ccen-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants