Update icons in paymentsheet #4328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyler-stripe
requested review from
brnunes-stripe,
ccen-stripe and
michelleb-stripe
as code owners
|
Diffuse output: |
ccen-stripe
approved these changes
Oct 27, 2021
| @@ -1,23 +1,18 @@ | |||
| <vector xmlns:android="http://schemas.android.com/apk/res/android" | |||
There was a problem hiding this comment.
I think this changed it to the wrong icon. I think it is now the discover icon?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update icons within payment sheet so that they're all the same size and match the colors in the mocks. I also removed tinting so that we can use the icons directly provided by the mocks.
edit: also removed specific amex error per request and made it use the same as the other fields.
Motivation
This was an ask from JJ to fix. She has approved the new look.
Testing
Screenshots